[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]commit from multiple wc

From: HuiHuang <yellow.flying_at_yahoo.com.cn>
Date: Tue, 14 Jul 2009 11:22:01 +0800

>> + /* Commit from each working copy in turn */
>> + if (!lock_err)
>> + {

>Wrong indentation here.
>Also, shouldn't this be "if (lock_err)", without "!" ?
>And you will have to check whether the error really means "wc not locked".
I think there is confusion since the comment I made is not very clear, sorry
about this.

Here if no error happens, we just try to do commit as svn_client_commit4()
originally do. So it should be if (!lock_err).

>> + commit_info_p = NULL;

>You'll need to clear the lock error here.
>> + if (! cmt_err)
>> + {
>> + SVN_ERR(do_one_single_commit(&commit_info_p, base_dir_access,
>> + base_dir, rel_targets,
>> + depth, keep_locks, keep_changelists,
>> + changelists, revprop_table, ctx, pool));
>> + if (commit_info_p)
>> + APR_ARRAY_PUSH(*commit_info, svn_commit_info_t *) = commit_info_p;
>> + return SVN_NO_ERROR;

>Do you really want to return here?
>Won't returning abort our loop over the working copies?
Yes. Here we commit successfully(The same as svn_client_commit4() do), so we
could return.

So as the new plan If there are no errors when do commit, we just commit as
svn_client_commit4() do. Above if phase is to deal with this condition.
Otherwise, if here there are errors, we will commit from multiple wcs in turn.

I will make the comment clearly so you can see what I am tring to do.

Thank you~


Received on 2009-07-14 05:23:46 CEST

This is an archived mail posted to the Subversion Dev mailing list.