[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch Manager additional task?

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sun, 12 Jul 2009 19:45:21 +0300 (Jerusalem Daylight Time)

Gavin Baumanis wrote on Mon, 13 Jul 2009 at 01:32 +1000:
> A non-committer submits a patch to the project.
> The patch is reviewed by another non-committer.
> There may or may not be some corrections / amendments - but
> ultimately, the patch is reviewed favorably.
>
> The issue is this use-case, is that the patch submission now
> languishes in a "void" of sorts.
> It's been reviewed, but does not get committed.
>
> ...
>
> Ultimately, my question is;
> For the specific use-case above is it appropriate for the PM to commit
> the "languishing" patch submission?
>

And if a bug is found in code that entered the repository this way, who is
responsible for it?

> So testing code will certainly be "easy enough" and I'd certainly like
> to think that my svn "technical" skills will get better the more I am
> involved, but is it enough?
>

Testing does not substitute review: if you tested a patch but don't feel
your skills allow you to +1 it, then (IMO) you shouldn't commit it.

Daniel

> Really, It's a case of whether or not you feel it is a task you want
> the PM doing?

> Anyway - I put it out there for discussion.
>
> Gavin.

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2370767
Received on 2009-07-12 18:45:59 CEST

This is an archived mail posted to the Subversion Dev mailing list.