[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r38388 - trunk/subversion/mod_dav_svn/reports

From: Paul Burba <ptburba_at_gmail.com>
Date: Thu, 9 Jul 2009 15:56:32 -0400

Thanks for the catch Dave. I nominated and added you as a +1 for
backport (as I assume your e-mail implies, if for some reason that is
not the case let me know).

Paul

On Thu, Jul 9, 2009 at 2:31 PM, David Glasser<glasser_at_davidglasser.net> wrote:
> This should be backported to 1.6.
>
> --dave
>
> On Thu, Jul 9, 2009 at 11:19 AM, David Glasser<glasser_at_davidglasser.net> wrote:
>> Author: glasser
>> Date: Thu Jul  9 11:19:10 2009
>> New Revision: 38388
>>
>> Log:
>> * subversion/mod_dav_svn/reports/deleted_rev.c
>>  (dav_svn__get_deleted_rev_report): Initialize variables which may not get
>>   assigned to if user input isn't complete.
>>
>> Modified:
>>   trunk/subversion/mod_dav_svn/reports/deleted-rev.c
>>
>> Modified: trunk/subversion/mod_dav_svn/reports/deleted-rev.c
>> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/mod_dav_svn/reports/deleted-rev.c?pathrev=38388&r1=38387&r2=38388
>> ==============================================================================
>> --- trunk/subversion/mod_dav_svn/reports/deleted-rev.c  Thu Jul  9 10:56:05 2009        (r38387)
>> +++ trunk/subversion/mod_dav_svn/reports/deleted-rev.c  Thu Jul  9 11:19:10 2009        (r38388)
>> @@ -43,8 +43,9 @@ dav_svn__get_deleted_rev_report(const da
>>  {
>>   apr_xml_elem *child;
>>   int ns;
>> -  const char *rel_path, *abs_path;
>> -  svn_revnum_t peg_rev, end_rev, deleted_rev;
>> +  const char *rel_path = NULL, *abs_path;
>> +  svn_revnum_t peg_rev = SVN_INVALID_REVNUM, end_rev = SVN_INVALID_REVNUM,
>> +      deleted_rev;
>>   apr_bucket_brigade *bb;
>>   svn_error_t *err;
>>   apr_status_t apr_err;
>>
>> ------------------------------------------------------
>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=2369465
>>
>
>
>
> --
> glasser_at_davidglasser.net | langtonlabs.org | flickr.com/photos/glasser/
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2369470
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2369483
Received on 2009-07-09 21:56:54 CEST

This is an archived mail posted to the Subversion Dev mailing list.