[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r38362 - trunk/subversion/libsvn_wc

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 7 Jul 2009 15:50:32 +0200

On Tue, Jul 7, 2009 at 15:35, Hyrum K.
Wright<hyrum_wright_at_mail.utexas.edu> wrote:
> On Jul 7, 2009, at 4:35 AM, Greg Stein wrote:
>> On Tue, Jul 7, 2009 at 04:45, Hyrum K. Wright<hyrum_at_hyrumwright.org>
>> wrote:
>>>
>>> ...
>>> +++ trunk/subversion/libsvn_wc/diff.c   Mon Jul  6 19:45:13 2009
>>>  (r38362)
>>> @@ -481,9 +481,10 @@ get_base_mimetype(const char **mimetype,
>>>  static svn_error_t *
>>>  get_working_mimetype(const char **mimetype,
>>>                     apr_hash_t **workingprops,
>>> -                     svn_wc_adm_access_t *adm_access,
>>> -                     const char *path,
>>> -                     apr_pool_t *pool)
>>> +                     const char *local_abspath,
>>> +                     svn_wc__db_t *db,
>>> +                     apr_pool_t *result_pool,
>>> +                     apr_pool_t *scratch_pool)
>>>  {
>>
>> I'll note that precedent seems to be <db, abspath> ordering. (or
>> <wc_ctx, abspath>)
>
> I've actually just been replacing arguments, and not worrying so much about
> ordering.  I figure once we're to the point where all the APIs are using the
> ctx/db local_abspath pair, we can go back and do a mass parameter order
> reshuffling.

Ha! You know that won't happen :-P

Not saying to go back and change that one "right now" (since it is a
very small nit), but I'd request to keep the ordering in mind.

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2368852
Received on 2009-07-07 15:50:50 CEST

This is an archived mail posted to the Subversion Dev mailing list.