[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: question on headers

From: Blair Zajac <blair_at_orcaware.com>
Date: Mon, 6 Jul 2009 23:28:02 -0700

On Jul 6, 2009, at 8:45 PM, Edmund Wong wrote:

> Blair Zajac wrote:
>
>> What do you mean by headers? You mean C header files? What do you
>> want to add?
>>
> I meant C header files., i.e. svn_wc.h
>
> I'm attempting issue #3342, and don't want to complicate the
> existing headers by adding conflict stats to them and maybe another
> reason is I'm not even sure if the header content belong to any of the
> current headers. Currently, conflict stats are placed in the
> notify_baton, and my intention is taking them out of the notify_baton
> and sticking them in a new struct, say:
>
> struct svn_conflict_stats {
> ...stats here..
>
> } svn_conflict_stats_t
>
> and place it in a new header, say svn_conflict_stat.h. But
> I'm getting the feeling that it would be frowned upon as it
> would add one more file to the bunch.

Yes, just put it in an existing file.

>> Contributors must sign one of the following depending if they are
>> an individual
>> or corporation:
>>
>> http://subversion.org/legal/individual-cla.html
>> http://subversion.org/legal/corporate-cla.txt
>
> Does this also apply to patches?

I'm not a lawyer, but my sense is that any patch over N lines would
require this, where N is probably a small number like 5.

Blair

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2368657
Received on 2009-07-07 08:33:40 CEST

This is an archived mail posted to the Subversion Dev mailing list.