[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r38350 - trunk/subversion/libsvn_ra_serf

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Mon, 06 Jul 2009 14:10:38 -0400

Greg Stein wrote:
> On Mon, Jul 6, 2009 at 19:57, C. Michael Pilato<cmpilato_at_collab.net> wrote:
>> ...
>> +++ trunk/subversion/libsvn_ra_serf/locks.c Mon Jul 6 10:57:58 2009 (r38350)
>> ...
>> @@ -411,7 +410,6 @@ handle_lock(serf_request_t *request,
>> _("Lock request failed: %d %s"),
>> ctx->status_code, ctx->reason));
>> }
>> -
>> SVN_ERR(err);
>> }
>
> Looks like you missed another chance for a simple "return err;" here.
>
> Then, the following "else" clause can then go away, and the "return
> SVN_NO_ERROR;" at the very end of the function can go away.

As in r38351?

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2368470

Received on 2009-07-06 20:14:00 CEST

This is an archived mail posted to the Subversion Dev mailing list.