[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r38301 - trunk/subversion/bindings/swig/perl/native

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 2 Jul 2009 14:12:47 +0100

On Thu, Jul 02, 2009 at 02:38:18PM +0200, Arfrever Frehtes Taifersar Arahesis wrote:
> 2009-07-02 14:20 Stefan Sperling <stsp_at_elego.de> napisał(a):
> > Author: stsp
> > Date: Thu Jul  2 05:20:57 2009
> > New Revision: 38301
> >
> > Log:
> > * subversion/bindings/swig/perl/native/Makefile.PL.in: Don't apply
> >   -Werror to implicit declaration warnings here, for now. There are
> >   a lot of warnings like this and erroring out on those masks other
> >   build problems.
> >
> > Modified:
> >   trunk/subversion/bindings/swig/perl/native/Makefile.PL.in
> >
> > Modified: trunk/subversion/bindings/swig/perl/native/Makefile.PL.in
> > URL: http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/swig/perl/native/Makefile.PL.in?pathrev=38301&r1=38300&r2=38301
> > ==============================================================================
> > --- trunk/subversion/bindings/swig/perl/native/Makefile.PL.in   Thu Jul  2 03:41:08 2009        (r38300)
> > +++ trunk/subversion/bindings/swig/perl/native/Makefile.PL.in   Thu Jul  2 05:20:57 2009        (r38301)
> > @@ -30,6 +30,13 @@ my @ldmodules = map {"-lsvn_$_-1"} (@mod
> >  my $apr_shlib_path_var = '@SVN_APR_SHLIB_PATH_VAR@';
> >  my $cppflags = '@CPPFLAGS@';
> >  my $cflags = '@CFLAGS@';
> > +
> > +# ### There are many "implicit function declaration" warnings in the perl
> > +# bindings. They should probably be fixed properly, but to avoid breaking
> > +# the build don't treat them as fatal errors for now like we do in the
> > +# core libraries of Subversion.
> > +$cflags =~ s/-Werror=implicit-function-declaration//;
>
> -0.5
>
> What version of SWIG do you use? I'm not able to reproduce these exact
> warnings in any SWIG bingings.

You're right that the commit was wrong.

The warning messages I've tried changing from errors to warnings are like this:

/usr/lib/perl/5.10/CORE/perl.h:1314: warning: redundant redeclaration
  of `strerror'

This is probably specific to Debian Lenny?

I somehow misread is as "error:" instead of "warning:", and assumed
the warning made the build fail. But in fact the only error is the
one about the global_pool not defined as is being discussed in another
thread. I was confused by the huge amount of warnings I'm getting in
the bindings and ended up trying to fix a problem which did not exist :-/

$ make swig-pl 2>&1 | grep warning: | wc -l
1140

> FYI, the following warnings cannot be ignored:
> assignment makes pointer from integer without a cast
> initialization makes pointer from integer without a cast
> return makes pointer from integer without a cast
> passing arg ... of `...' makes pointer from integer without a cast
> passing arg ... of pointer to function makes pointer from integer without a cast
> cast to pointer from integer of different size

Maybe you misunderstood what I wanted to do?

All warnings can stay, they are fine.
I was not planning on making any warnings be ignored.
I just dind't want the bindings build to _error_ out on the warnings.
See the diff I committed again. It filters a -Werror flag, nothing else.

But as I said above the diff is not right so I'll revert it.

Thanks,
Stefan
Received on 2009-07-02 15:13:15 CEST

This is an archived mail posted to the Subversion Dev mailing list.