[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix for issue 3438

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: Tue, 30 Jun 2009 18:36:52 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Julian Foad wrote:
> I (Julian Foad) wrote:
>> On Mon, 2009-06-29 at 21:36 +0530, Kamesh Jayachandran wrote:
>>> Attached patch fixes issue 3438.
>>>
>>> I would like to get some review before committing.
>> Doesn't the function svn_path_url_add_component2() do exactly what you
>> want here?
>
> Answering myself: no, I don't think it does, exactly, but my point is
> that there should be a simple function to do this. It would be good to
> create one (locally, perhaps) so that the flow of code remains easy to
> read.
>
> - Julian
>
>

Thanks for pointing 'svn_path_url_add_component2' it works here provided
we pass non-absolute copyfrom_path(i.e by passing copyfrom_path+1).

Committed in r38264

With regards
Kamesh Jayachandran
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFKSg3r3WHvyO0YTCwRAiqjAJ9gZlVxblKnEw3HS2QqlRcxF4780gCgrPKk
PUVMZNJwAljvdf+ooyqU7qA=
=SRxc
-----END PGP SIGNATURE-----

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2366701
Received on 2009-06-30 15:07:26 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.