[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r38202 - trunk/subversion/libsvn_wc

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 26 Jun 2009 07:37:25 +0200

On Fri, Jun 26, 2009 at 06:19, Hyrum K.
Wright<hyrum_wright_at_mail.utexas.edu> wrote:
>> Looking at the code, I think what you really want is to examine
>> parent_relpath, NOT do a LIKE clause.
> The real problem here is getting the transitive closure on all the nodes
> which have a given parent.  So while using parent_relpath would find all the
> immediate children, we'd need to continue to recurse to nail every potential
> child node.  That is, unless not grasping an important bit of our repository
> information inheritance scheme.

Ah. Hrm. Right... This isn't the "relocate the children" thing (in
another rev), but "relocate the tree".


Okee dokey, then. Seems fine, except that you used apr_pcalloc() when
a palloc would be just fine. You're filling every byte manually, so
there is no reason to zero it beforehand.


Received on 2009-06-26 07:37:57 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.