[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r38094 - trunk/subversion/tests

From: Hyrum K. Wright <hyrum_at_hyrumwright.org>
Date: Thu, 25 Jun 2009 16:10:49 -0500

On Jun 25, 2009, at 3:52 PM, David Glasser wrote:

> So do you care about backwards compatibility of these symbols or not?
> If you don't care, adding a "2" to everything is confusing and
> unnecessary.
> If you do care, then this change technically does break compatibility
> in a perhaps-1.x-inappropriate way. (It is certainly the case that
> there exist codebases which are forks of Subversion which use the svn
> test driver to run their own tests in addition to Subversion's C
> tests, all of which will be broken by this revision.)
> I won't go so far as to actually object to this change, but well, if
> you're going to be a pain to codebases outside of Subversion trunk
> anyway, you might as well just reuse the old names...

Our public API has always been exclusive to what is included in
subversion/include/ and the tests clearly fall outside that scope. (I
actually had questions about this myself prior to making this change,
but others on IRC confirmed it.) That being the case, I find it
difficult to understand why we should maintain symbols in svn_test.h
which aren't used anywhere in our own codebase, hence r38094. I may
be wrong here, and if I am, let's make a decision about what our
public API does encompass.

As far as names go, the point behind the "2" was to allow both the old
and new macros prior to the switch to the new style. That being done,
the old were removed. I suppose somebody could rename the "2" macros
back to the original names, and I've no objection to that. But nor do
I have the time or inclination to do so myself just now.


Received on 2009-06-25 23:11:16 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.