[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r38193 - trunk/subversion/libsvn_subr

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Thu, 25 Jun 2009 16:22:08 +0100

I (Julian Foad) wrote:
> > > > /* Return the first eol marker found in [@a buf, @a endp) as a
> > > > * NUL-terminated string, or NULL if no eol marker is found.
> > > > *
> > > > * If the last valid character of @a buf is the first byte of a
> > > > * potentially two-byte eol sequence, just return "\r", that is,
> > >
> > > Shouldn't it return what's there (which could be "\n" or "\r") rather
> > > than always "\r" ...
> > >
> > > > * assume @a buf represents a CR-only file. This is correct for callers
> > >
> > > ... and "CR-only or LF-only"?
> >
> > I don't know. The function has always been doing this, even
> > while it was still a static function in libsvn_diff.
> > I don't want to change this behaviour because I'd have to tweak
> > the callers, too.
>
> I looked at the implementation. It does what I thought it should. The
> doc string's wrong.

Fixed in revision 38201.

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2365334
Received on 2009-06-25 17:22:36 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.