Re: svn commit: r38188 - in trunk/subversion: include libsvn_diff libsvn_subr
On Wed, Jun 24, 2009 at 10:49:38AM -0700, Blair Zajac wrote:
> Stefan Sperling wrote:
> > Author: stsp
> > Date: Wed Jun 24 10:40:08 2009
> > New Revision: 38188
> > Log:
> > Promote two static functions from libsvn_diff to public API.
> > No functional change.
> > The functions will be useful for 'svn patch', which needs to call
> > them from libsvn_client. Lacking a better idea of where to move them,
> > I am moving them into libsvn_subr/subst.c which already concerns
> > itself with EOL characters in one way or another.
> > * subversion/include/svn_subst.h
> > (svn_subst_find_eol_start, svn_subst_detect_eol): Declare.
> > * subversion/libsvn_diff/diff_file.c
> > (datasource_get_next_token, output_unified_line, output_line,
> > svn_diff_file_output_merge2): Track renamed functions.
> > (find_eol_start, detect_eol): Moved from here ...
> > * subversion/libsvn_subr/subst.c
> > (svn_subst_find_eol_start, svn_subst_detect_eol): ... to here.
> > Modified:
> > trunk/subversion/include/svn_subst.h
> > trunk/subversion/libsvn_diff/diff_file.c
> > trunk/subversion/libsvn_subr/subst.c
> > Modified: trunk/subversion/include/svn_subst.h
> > URL: http://svn.collab.net/viewvc/svn/trunk/subversion/include/svn_subst.h?pathrev=38188&r1=38187&r2=38188
> > ==============================================================================
> > --- trunk/subversion/include/svn_subst.h Wed Jun 24 08:23:22 2009 (r38187)
> > +++ trunk/subversion/include/svn_subst.h Wed Jun 24 10:40:08 2009 (r38188)
> > @@ -565,6 +565,30 @@ svn_error_t *svn_subst_detranslate_strin
> > svn_boolean_t for_output,
> > apr_pool_t *pool);
> > +/* Generic EOL character helper routines */
> > +
> > +/* Look for the start of an end-of-line sequence (i.e. CR or LF)
> Does that include CRLF also? If it does, then I think the
> documentation should
> include it to be as comprehensive as possible, otherwise people like me are
> going to dig into the source code to find out :)
CR is the start of CRLF.
Received on 2009-06-24 19:53:46 CEST
This is an archived mail posted to the Subversion Dev