On Wed, Jun 24, 2009 at 04:56:15PM +0200, Bert Huijben wrote:
> > @@ -465,6 +465,9 @@ typedef struct svn_client_commit_item3_t
> > * same lifetime as this data structure.
> > */
> > apr_array_header_t *outgoing_prop_changes;
> > +
> > + /** adm_access of this item */
> > + svn_wc_adm_access_t *adm_access;
> > } svn_client_commit_item3_t;
> This addition needs a @since doxygen tag, and probably a '###' suggesting
> that this field should be removed once we have one global svn_wc_context_t,
> that can handle multiple working copies.
> (And personally I would prefer not to hand off adm_access instances to third
> party handlers of the logmessage callback, because you are not supposed to
> do any working copy operations in this state).
Well, commit items as a data type are also used for other things apart
from writing log messages. Would you rather create a new data type?
Received on 2009-06-24 17:28:24 CEST