Re: commit crash over serf

I'd love to know ... I didn't spot any immediate issues.

Lieven Govaerts wrote:
> I have a small patch that solves the issue, as soon as I have figured
> out why it's doing what it seems to be doing I'll commit the patch.
>
> Lieven
>
> On Tue, Jun 23, 2009 at 9:04 PM, C. Michael Pilato<cmpilato_at_collab.net> wrote:
>> The NULL path passed to svn_ra_serf__set_prop() doesn't look good. I'll see
>> what I can find.
>>
>>
>> Daniel Shahaf wrote:
>>> [ because stsp can't start threads now ]
>>>
>>> stsp and I are seeing segfaults when committing to s.c.n over serf.
>>> (I'm using today's serf + today's trunk svn.) Backtraces pasted
>>> to <http://paste.lisp.org/display/82350>, and repeated below.
>>>
>>> Daniel
>>>
>>> [[[
>>> Program received signal SIGSEGV, Segmentation fault.
>>> [Switching to Thread 0xb6420720 (LWP 27207)]
>>> apr_hashfunc_default (char_key=0x0, klen=0xbfbf0c80) at tables/apr_hash.c:228
>>> 228 for (p = key; *p; p++) {
>>> (gdb) bt
>>> #0 apr_hashfunc_default (char_key=0x0, klen=0xbfbf0c80) at tables/apr_hash.c:228
>>> #1 0xb7ce347b in find_entry (ht=0x8f4f900, key=0x0, klen=-1, val=0x0) at tables/apr_hash.c:260
>>> #2 0xb7ce356f in apr_hash_get (ht=0x8f4f900, key=0x0, klen=-1) at tables/apr_hash.c:330
>>> #3 0xb7ecd223 in svn_ra_serf__set_ver_prop (props=0x8f4f830, path=0x0, rev=-1,
>>> ns=0xb7edd7dc "http://subversion.tigris.org/xmlns/svn/", name=0x909be1c "log", val=0x909be10,
>>> pool=0x8f4f0e0) at subversion/libsvn_ra_serf/property.c:186
>>> #4 0xb7ecd346 in svn_ra_serf__set_prop (props=0x8f4f830, path=0x0,
>>> ns=0xb7edd7dc "http://subversion.tigris.org/xmlns/svn/", name=0x909be1c "log", val=0x909be10,
>>> pool=0x8f4f0e0) at subversion/libsvn_ra_serf/property.c:216
>>> #5 0xb7ec347e in open_root (edit_baton=0x909b880, base_revision=-1, dir_pool=0x8f4f0e0,
>>> root_baton=0xbfbf0dfc) at subversion/libsvn_ra_serf/commit.c:1245
>>> #6 0xb7f6ca8f in svn_delta_path_driver (editor=0x909bf08, edit_baton=0x909b880, revision=-1,
>>> paths=0x909c190, callback_func=0xb7f8bbf1 <do_item_commit>, callback_baton=0xbfbf0eb0,
>>> pool=0x8e09968) at subversion/libsvn_delta/path_driver.c:168
>>> #7 0xb7f8cbe5 in svn_client__do_commit (
>>> base_url=0x8e27668 "https://svn.collab.net/repos/svn/trunk/subversion/tests/cmdline",
>>> commit_items=0x8e26ad8, adm_access=0x8f6eb38, editor=0x909bf08, edit_baton=0x909b880,
>>> notify_path_prefix=0x909c088 "/home/daniel/src/svn/trunk/subversion/tests/cmdline",
>>> tempfiles=0xbfbf0fd4, checksums=0xbfbf0fd0, ctx=0x8e0a7d0, pool=0x8e09968)
>>> at subversion/libsvn_client/commit_util.c:1623
>>> #8 0xb7f890e5 in svn_client_commit4 (commit_info_p=0xbfbf10cc, targets=0x8e1be40,
>>> depth=svn_depth_infinity, keep_locks=0, keep_changelists=0, changelists=0x8e0a020,
>>> revprop_table=0x0, ctx=0x8e0a7d0, pool=0x8e09968) at subversion/libsvn_client/commit.c:1660
>>> #9 0x0804f18a in svn_cl__commit (os=0x8e09b08, baton=0xbfbf1224, pool=0x8e09968)
>>> at subversion/svn/commit-cmd.c:114
>>> #10 0x0805a52b in main (argc=5, argv=0xbfbf1454) at subversion/svn/main.c:2110
>>> (gdb)
>>> ]]]
>>>
>>> ------------------------------------------------------
>>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2364626
>>
>> --
>> C. Michael Pilato <cmpilato_at_collab.net>
>> CollabNet <> www.collab.net <> Distributed Development On Demand
>>
>> ------------------------------------------------------
>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2364631

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2364669