[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix python wc testcase failure

From: Hyrum K. Wright <hyrum_at_hyrumwright.org>
Date: Mon, 22 Jun 2009 09:29:53 -0500

On Jun 21, 2009, at 5:01 AM, Jens Peters wrote:

> Hello there,
> I did some research/debugging to get to the ground of this test
> failure:
> http://svn.haxx.se/dev/archive-2009-05/0087.shtml
> It turns out that its just a mix up of wc.get_status_editor2
> arguments.
> The following patch fixes that, at least for me.
> With this patch I can finally finish the python without a failure
> (yes :)).
> Regards,
> jens
> [[[
> Fix a python wc testcase failure.
> (SubversionException, "Can't check path '[path][path]': The filename,
> directory name, or volume label syntax is incorrect.")
> * subversion/bindings/swig/python/tests/wc.py
> (test_status_editor):
> Put the correct arguments into 'wc.get_status_editor2'. The second
> argument should be 'target'.
> Patch by: Jens Peters <jpeters7677 { at } gmx.de>
> ]]]

Hmmm, I wonder if this is really a problem with the underlying
backward compat C code. The test presumably passed when it was
originally added, but when the underlying APIs got rewritten, there
may be some bugs in the backward compatibility wrapper. If that's the
case, we should fix the bugs there, not in the python testsuite.

Caveat: I haven't looked at the history of this test, or the
underlying code, so I could be completely making stuff up. But it's a


Received on 2009-06-22 16:30:16 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.