[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: testBatonPlay in the Python bindings testsuite fails

From: Роман Донченко <DXDragon_at_yandex.ru>
Date: Sun, 21 Jun 2009 01:38:27 +0400

David James <james82_at_gmail.com> писал(а) в своём письме Sat, 20 Jun 2009
23:50:22 +0400:

> 2009/6/17 David James <james82_at_gmail.com>:
>> 2009/6/16 Роман Донченко <DXDragon_at_yandex.ru>:
>>> ...
>>> ~
>>> F............
>>> ======================================================================
>>> FAIL: Test playing with C batons
>>> ----------------------------------------------------------------------
>>> Traceback (most recent call last):
>>>    File "client.py", line 54, in testBatonPlay
>>>      str(self.client_ctx.auth_baton))
>>> AssertionError: "<libsvn.core.svn_auth_baton_t; proxy of <Swig Object
>>> of
>>> type 's
>>> vn_auth_baton_t *' at 0x01561C20> >" != "<libsvn.core.svn_auth_baton_t;
>>> proxy of
>>>   <Swig Object of type 'svn_auth_baton_t *' at 0x01561C00> >"
>>>
>>> ----------------------------------------------------------------------
>>> Ran 13 tests in 27.438s
>>>
>>> FAILED (failures=1)
>>> ~
>>> ...
>>
>> ...
>> An alternative way to do the same test would be to use weak
>> references. See the test_pool function in pool.py. In this case, we
>> would need to do the following:
>>   1) Add a weak reference to our baton
>>   2) Add our baton to the client context
>>   3) Delete all references to our baton except the reference in the
>> client context
>>   4) Verify that our baton is still around via the weak reference
>>   5) Delete the client context
>>   6) Verify the baton is deleted
>> ...
>
> Hi Roman,
>
> I went ahead and reimplemented the test using weak references in
> r38118. This avoids any dependency on how SWIG stringifies objects.
>
> Roman, could you test this new version of the test with your version
> of SWIG and let me know if it fixes the problem?

Yep, all tests in client.py pass now.

Roman.

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2363827
Received on 2009-06-20 23:39:04 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.