[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: parameter name of svn_fs_paths_changed2() -- was: Re: SWIG (Perl) prospective patch

From: John Beranek <john_at_redux.org.uk>
Date: Tue, 16 Jun 2009 15:36:29 +0100

Neels J Hofmeyr wrote:
> BTW, John, you can create a patch comfortably by making your changes in an
> actual working copy and then running "svn diff" in the working copy root
> (usually from trunk, but using 1.6.1 like you did:
> "
> svn co https://svn.collab.net/repos/svn/tags/1.6.1
> <edit> ./1.6.1/**
> svn diff ./1.6.1 > patch.file
> "). That's the standard form normally circulating around here.

I admit that would be better, but I hadn't yet gone the whole way to
getting a copy of Subversion out of Subversion, making changes there and
building - even if that method is arguably much tidier than an SRPM
build environment.

Patch against tags/1.6.1 attached, my previous patch applied cleanly.


John Beranek                         To generalise is to be an idiot.
http://redux.org.uk/                                 -- William Blake

Index: subversion/bindings/swig/svn_fs.i
--- subversion/bindings/swig/svn_fs.i (revision 38045)
+++ subversion/bindings/swig/svn_fs.i (working copy)
@@ -57,6 +57,7 @@
 %hash_argout_typemap(entries_p, svn_fs_dirent_t *)
 %hash_argout_typemap(changed_paths_p, svn_fs_path_change_t *)
+%hash_argout_typemap(changed_paths2_p, svn_fs_path_change2_t *)
 #ifndef SWIGPERL
 %callback_typemap(svn_fs_get_locks_callback_t get_locks_func,
Index: subversion/bindings/swig/perl/native/Fs.pm
--- subversion/bindings/swig/perl/native/Fs.pm (revision 38045)
+++ subversion/bindings/swig/perl/native/Fs.pm (working copy)
@@ -259,6 +259,14 @@
 are C<_p_svn_fs_path_change_t> objects which contain information about
 what kind of changes are made.
+=item $root-E<gt>paths_changed2()
+A reference to a hash indicating what changes are made in the root.
+The keys are the paths of the files changed, starting with C</> to
+indicate the top-level directory of the repository. The values
+are C<_p_svn_fs_path_change2_t> objects which contain information about
+what kind of changes are made.
 =item $root-E<gt>revision_link
 =item $root-E<gt>revision_root_revision
@@ -276,7 +284,7 @@
                  file_length file_md5_checksum is_dir is_file
                  is_revision_root is_txn_root make_dir make_file
                  node_created_rev node_history node_id node_prop
- node_proplist paths_changed revision_link
+ node_proplist paths_changed paths_changed2 revision_link
 *fs = *SVN::Fs::root_fs;
@@ -481,4 +489,10 @@
 package SVN::Fs::PathChange;
 use SVN::Base qw(Fs svn_fs_path_change_);
+package _p_svn_fs_path_change2_t;
+use SVN::Base qw(Fs svn_fs_path_change2_t_);
+package SVN::Fs::PathChange2;
+use SVN::Base qw(Fs svn_fs_path_change2_);
Index: subversion/include/svn_fs.h
--- subversion/include/svn_fs.h (revision 38045)
+++ subversion/include/svn_fs.h (working copy)
@@ -1137,7 +1137,7 @@
  * @since New in 1.6.
 svn_error_t *
-svn_fs_paths_changed2(apr_hash_t **changed_paths_p,
+svn_fs_paths_changed2(apr_hash_t **changed_paths2_p,
                       svn_fs_root_t *root,
                       apr_pool_t *pool);

Received on 2009-06-16 16:37:11 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.