Re: svn commit: r38015 - trunk/subversion/tests/cmdline

On Fri, Jun 12, 2009 at 10:29 AM, Bert Huijben<rhuijben_at_sharpsvn.net> wrote:
> Author: rhuijben
> Date: Fri Jun 12 07:29:18 2009
> New Revision: 38015
>
> Log:
> Add new test to show double delete issue in Subversion 1.6.x.
> (It appears the WC-NG work fixed this issue)
>
> * tests/cmdline/basic_tests.py
>  (delete_keep_local_twice): New test to show 1.6.x issue.
>  (test_list): Add new test.
>
> Modified:
>   trunk/subversion/tests/cmdline/basic_tests.py
>
> Modified: trunk/subversion/tests/cmdline/basic_tests.py
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/tests/cmdline/basic_tests.py?pathrev=38015&r1=38014&r2=38015
> ==============================================================================
> --- trunk/subversion/tests/cmdline/basic_tests.py       Fri Jun 12 06:55:18 2009        (r38014)
> +++ trunk/subversion/tests/cmdline/basic_tests.py       Fri Jun 12 07:29:18 2009        (r38015)
> @@ -1847,6 +1847,23 @@ def delete_keep_local(sbox):
>                                         expected_disk,
>                                         expected_status)
>
> +def delete_keep_local_twice(sbox):
> +  'delete file and directory with --keep-local 2 times'
> +
> +  sbox.build()
> +  wc_dir = sbox.wc_dir
> +
> +  dir = os.path.join(wc_dir, 'dir')
> +
> +  svntest.actions.run_and_verify_svn(None, None, [], 'mkdir', dir)
> +
> +  svntest.actions.run_and_verify_svn(None, None, [], 'rm', '--keep-local', dir)
> +  svntest.actions.run_and_verify_svn(None, None, [], 'rm', '--keep-local', dir)
> +
> +  if not os.path.isdir(dir):
> +    print 'Directory was really deleted'
> +    raise svntest.Failure
> +
>  def windows_paths_in_repos(sbox):
>   "use folders with names like 'c:hi'"
>
> @@ -2488,6 +2505,7 @@ test_list = [ None,
>               cat_added_PREV,
>               ls_space_in_repo_name,
>               delete_keep_local,
> +              delete_keep_local_twice,
>               windows_paths_in_repos,
>               basic_rm_urls_one_repo,
>               XFail(basic_rm_urls_multi_repos),

Hi Bert,

I think it's best if we always add new tests to the end of the list.
That way when someone refers to a test by number only, e.g.
"basic_tests.py 43", it always refers to the same test.

Paul

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2362186
Received on 2009-06-15 16:03:15 CEST