[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] commit_tests

From: Stefan Sperling <stsp_at_elego.de>
Date: Sun, 14 Jun 2009 14:08:38 +0100

On Sat, Jun 13, 2009 at 02:22:01PM +0100, Stefan Sperling wrote:
> So, to be clear, I meant something like:

> @@ -1384,14 +1387,16 @@
> expected_status2.tweak('A/B/lambda', status='M ')
> svntest.actions.run_and_verify_status(wc2_dir, expected_status2)
> - # Commit should fail, even though one target is a "child" of the other.
> - svntest.actions.run_and_verify_svn("Unexpectedly not locked",
> - None, svntest.verify.AnyOutput,
> + # Commit should succeed, even though one target is a "child" of the other,
> + # since both working copies come from the same repository.
> + svntest.actions.run_and_verify_svn(None, None, svntest.verify.AnyOutput,
> 'commit', '-m', 'log',
> wc_dir, wc2_dir)

This example was actually totally wrong.
The function call contradicts the comment above it,
and uses None instead of [].

So this led you to copy those errors into the patch you submitted.
I will try to be more careful when providing examples in the future.

I even ended up committing this wrong code in r38030 :(
What I really meant to say is in r38031.

I hope I didn't confuse you too much,
Received on 2009-06-14 15:09:09 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.