[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] commit_tests

From: Neels Janosch Hofmeyr <neels_at_elego.de>
Date: Sun, 14 Jun 2009 01:24:49 +0200

Stefan Sperling wrote:
> +# Also related to issue #2381, "Cannot commit multiple WC paths which
> +# lack a common parent directory". Once that issue has been resolved,
> +# we will remove the XFail from this test.
> + # Commit should succeed, even though one target is a "child" of the other,

Stefan, I think HuiHuang wants them *not* to be parent-child related. His
point is that he also wants to test the case where we commit two WC paths
which are adjacent, but whose parent dir is not a WC itself.

> Do you see the difference between doing the above and what you proposed?

Still, HuiHuang, Stefan is right here. The tests should expect the desired
behaviour, no matter if the current svn really behaves like that.

If the current svn behaves wrong, that test fails.
If we know that the test will currently fail, we mark it XFail(..)
As soon as the behaviour is fixed, we see the test pass.

Good speed for you, HuiHuang! :)



Received on 2009-06-14 01:25:17 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.