[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] commit_tests

From: Stefan Sperling <stsp_at_elego.de>
Date: Sat, 13 Jun 2009 15:31:47 +0100

On Sat, Jun 13, 2009 at 10:34:06AM +0800, yellow.flying wrote:
> >Wait, there is something wrong in what we are doing!
> >It looks like I didn't give you good advice :(
> >After looking at commit_tests.py more closely, I realised that there
> >already is a test that does what we need!
> >It is the "commit_multiple_wc" test below which you put your test.
> >So instead of adding a new test, we can change the commit_multiple_wc
> >test to expect the commit to succeed instead of fail, and mark the
> >test XFail. Can you make a patch for that?
> I think you misunderstand me. Yes, I know that there is a test already,
> but I do not think the test is enough, you may observed that in the
> test the two wcs are nested, and I want test when the two wcs(which
> are from the same repository) are not nested. So I write
> commit_multiple_wc2. These two tests will both be used in our case.
> Do you think it is necessary to do like this?

OK, agreed.

Sorry about the confusion, I didn't look close enough to realise
the working copies were nested.

Maybe we should rename the first test to commit_multiple_wc_nested?

Received on 2009-06-13 16:32:09 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.