> -----Original Message-----
> From: Stefan Sperling [mailto:stsp_at_elego.de]
> Sent: donderdag 11 juni 2009 17:17
> To: Bert Huijben
> Cc: dev_at_subversion.tigris.org
> Subject: Re: svn commit: r37988 - in trunk/subversion: include
include/private
> libsvn_subr svn tests/cmdline
>
> On Thu, Jun 11, 2009 at 05:00:50PM +0200, Bert Huijben wrote:
> > > +/* Return, in @a *true_targets_p, a copy of @a targets with peg
revision
> > > + * specifiers snipped off the end of each element.
> > > + *
> > > + * This function is useful for subcommands for which peg revisions
> > > + * do not make any sense. Such subcommands still need to allow peg
> > > + * revisions to be specified on the command line so that users of
> > > + * the command line client can consistently escape '@' characters
> > > + * in filenames by appending an '@' character, regardless of the
> > > + * subcommand being used.
> > > + *
> > > + * If a peg revision is present but cannot be parsed, an error is
thrown.
> > > + * The user has likely forgotten to escape an '@' character in a
> filename.
> > > + *
> > > + * It is safe to pass the address of @a targets as @a true_targets_p.
> > > + *
> > > + * Do all allocations in @a pool. */
> > > +svn_error_t *
> > > +svn_opt_eat_peg_revisions(apr_array_header_t **true_targets_p,
> > > + apr_array_header_t *targets,
> > > + apr_pool_t *pool);
> > > +
> >
> > This new function needs a @since doxygen comment.
>
> What do we set it to? I'd like to backport it to 1.6.
>
> Should I set it to 1.7 for now, and make a note in STATUS that
> we should manually adjust the @since tag on trunk and 1.6.x
> if it gets backported?
We can't backport new public functions to 1.6 per our compatibility
guidelines. The usual method to work around this is to mark it as new in the
next version and backport a private version of the new function for use by
subversion only.
Bert
>
> Stefan
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2361326
Received on 2009-06-11 17:25:31 CEST