[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r37929 - trunk/subversion/libsvn_wc

From: Greg Stein <gstein_at_gmail.com>
Date: Sun, 7 Jun 2009 09:01:06 +0200

Ugh. Stupid rule.

On Thu, Jun 4, 2009 at 13:44, Hyrum K. Wright<hyrum_at_hyrumwright.org> wrote:
> Author: hwright
> Date: Thu Jun  4 04:44:14 2009
> New Revision: 37929
>
> Log:
> * subversion/libsvn_wc/relocate.c
>  (svn_wc_relocate3): Add some parenthesis.  While not strictly required, this
>    follows the counsel of HACKING to "be generous with parentheses even when
>    you're sure about the operator precedence".
>
> Modified:
>   trunk/subversion/libsvn_wc/relocate.c
>
> Modified: trunk/subversion/libsvn_wc/relocate.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_wc/relocate.c?pathrev=37929&r1=37928&r2=37929
> ==============================================================================
> --- trunk/subversion/libsvn_wc/relocate.c       Thu Jun  4 03:12:46 2009        (r37928)
> +++ trunk/subversion/libsvn_wc/relocate.c       Thu Jun  4 04:44:14 2009        (r37929)
> @@ -161,8 +161,8 @@ svn_wc_relocate3(const char *path,
>       svn_pool_clear(subpool);
>
>       if (recurse && (entry->kind == svn_node_dir)
> -          && (! entry->deleted || (entry->schedule == svn_wc_schedule_add))
> -          && ! entry->absent
> +          && ((! entry->deleted) || (entry->schedule == svn_wc_schedule_add))
> +          && (! entry->absent)
>           && (entry->depth != svn_depth_exclude))
>         {
>           svn_wc_adm_access_t *subdir_access;
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=2359401
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2360059
Received on 2009-06-07 09:01:26 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.