Re: svn_client_args_to_target_array and peg revisions -> no good

On Tue, Jun 02, 2009 at 01:38:22PM +0100, Julian Foad wrote:
> Stefan Sperling wrote:
> > On Sat, May 30, 2009 at 11:51:09AM +0100, Stefan Sperling wrote:
> > > I'll need more time diving into the matter to pin-point the exact
> > > cause of the problem.
> >
> > Still talking to myself here, but just following up with latest
> > thoughts in case anyone is listening.
>
> Hi Stefan. I'm listening!

Great! :)

Thanks for your comments. I agree that a quick short-term
fix could be made. I'd say we could add peg-rev parsing to all
subcommands (not just 'add') and port those changes back to 1.6.x.
On trunk, we can do the "proper" fix, transforming the target
array from an array of strings to an array of (name, reg-rev) pairs.

While I got you here, can you explain to me why we moved
client_args_to_target_array functionality from libsvn_subr
into libsvn_client?
I can't find the rational for the move in the log message of r30753.

See also r33317 which partly restored the functionality in libsvn_subr
as svn_opt__args_to_target_array(), so that e.g. svnadmin doesn't
need to link to libsvn_client.

Why can't we just put things in one place?

Thanks,
Stefan
Received on 2009-06-02 16:39:34 CEST