[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Memory leak with 1.6.x clients

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Mon, 01 Jun 2009 13:08:04 -0400

Paul Burba wrote:
> Avoid temp file name collisions when committing with ra_serf/ra_neon.
> * subversion/libsvn_ra_neon/commit.c
> (commit_apply_txdelta): Use svn_io_open_uniquely_named directly instead of
> svn_io_open_unique_file3. Avoid temp file naming collisions by basing the
> temp file name on BASE_CHECKSUM, or for new files which have no checksum,
> * subversion/libsvn_ra_serf/commit.c
> (apply_textdelta): Same as above, but use CTX->NAME instead of

Please just pick one uniqueness mechanism instead of two. The base_checksum
thing seems like it would just fall over when committing 10,000 empty files,

The "edit path" of the file would be necessarily unique, though, and a
checksum thereof almost as unique, but also less predictable. I'd go that

C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2009-06-01 19:08:22 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.