Re: Memory leak with 1.6.x clients

Paul Burba wrote:
> Avoid temp file name collisions when committing with ra_serf/ra_neon.
>
> * subversion/libsvn_ra_neon/commit.c
> (commit_apply_txdelta): Use svn_io_open_uniquely_named directly instead of
> svn_io_open_unique_file3. Avoid temp file naming collisions by basing the
> temp file name on BASE_CHECKSUM, or for new files which have no checksum,
> on FILE->RSRC->LOCAL_PATH.
>
> * subversion/libsvn_ra_serf/commit.c
> (apply_textdelta): Same as above, but use CTX->NAME instead of
> FILE->RSRC->LOCAL_PATH.

Please just pick one uniqueness mechanism instead of two. The base_checksum
thing seems like it would just fall over when committing 10,000 empty files,
right?

The "edit path" of the file would be necessarily unique, though, and a
checksum thereof almost as unique, but also less predictable. I'd go that
route.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2357597