[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] windows-WiX installer updated for 1.6.x

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sat, 30 May 2009 10:01:35 +0300 (Jerusalem Daylight Time)

Normally we can file the issue first and add the log message later...

But for a 100KB patch? I think the first issue is the reduce it to
managable size. Looking into it, one of the hunks has two 37K-character
lines. That consist mainly of changing some absolute local paths (which
shouldn't be versioned anyway). Perhaps we need to refactor that file (to
wrap it and remove the absolute local paths) first.

Gavin Baumanis wrote on Sat, 30 May 2009 at 12:38 +1000:
> Hi David,
> Just following up on this patch submission of yours.
> I was abut to log it into the issue tracker when I realised there
> wasn't "really" a log message for the patch.
> I was going to use your single line of text from your original mail,
> but thought I would check if you felt that was sufficient?
> Please refer to;
> http://subversion.tigris.org/hacking.html#patches
> for the patch submission guidelines - and of course feel free to ask
> for any help you might need.
> Gavin.
> On 25/04/2009, at 6:36 AM, David Darj wrote:
> > Patch for the packages/windows-WiX installer to handle the fact that
> > there are no binaries built for Apache 2.0 bindings<Svn-
> > WindowsWiX-1.6.diff>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2357047

Received on 2009-05-30 09:02:02 CEST

This is an archived mail posted to the Subversion Dev mailing list.