[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Patch] make parse-diff.c compile with VC6 (forgot to CC everyone)

From: Stefan Sperling <stsp_at_elego.de>
Date: Fri, 29 May 2009 12:00:19 +0100

On Fri, May 29, 2009 at 11:28:27AM +0200, Miha Vitorovic wrote:
> Branko Cibej <brane_at_xbc.nu> wrote on 29.05.2009 10:22:26:
>
> >
> > Well, to be pedantic, we usually include system headers before local
> > ones, not after 'em; but, http://beige.bikeshed.com/ . Approved.
> >
> > -- Brane
> But I distinctly remember someone stating the opposite right on this list
> - the reason being to catch local headers, that don't include required
> system ones. (I remember because as someone who hasn't done any C in
> years, I thought to myself - that's smart).
>

I'd say it's a matter of preference. It amounts to the question
of whether you want the header to be self-contained, or whether you
want to avoid including everything and the kitchen sink, making sure
that the program includes only required dependencies.

The first approach puts the burden on the header, the second approach
puts the burden on the program. Shrug.

Stefan
Received on 2009-05-29 13:00:43 CEST

This is an archived mail posted to the Subversion Dev mailing list.