[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

svn_wc__db_read_info (was: Re: svn commit: r37885 - trunk/subversion/libsvn_wc)

From: Stefan Sperling <stsp_at_elego.de>
Date: Fri, 29 May 2009 11:48:59 +0100

On Fri, May 29, 2009 at 01:29:07AM +0200, Greg Stein wrote:
> On Thu, May 28, 2009 at 23:43, Hyrum K. Wright <hyrum_at_hyrumwright.org> wrote:
> >...
> > +++ trunk/subversion/libsvn_wc/translate.c      Thu May 28 14:43:15 2009        (r37885)
> >...
> > @@ -300,16 +305,31 @@ svn_wc__get_keywords(apr_hash_t **keywor
> >   else
> >     list = force_list;
> >
> > -  SVN_ERR(svn_wc__entry_versioned(&entry, path, adm_access, FALSE, pool));
> > +  SVN_ERR(svn_wc__db_read_info(NULL, NULL, NULL, &repos_relpath,
> > +                               &repos_root_url, NULL, &changed_rev,
> > +                               &changed_date, &changed_author, NULL, NULL,
> > +                               NULL, NULL, NULL, NULL, NULL, NULL,
> > +                               NULL, NULL, NULL, NULL, NULL, NULL,
> > +                               db, local_abspath, scratch_pool, scratch_pool));

(I'm hijacking this thread because I cannot start new ones right now,
some tigris problem...)

Greg, I was wondering why we have functions that need to be called with
NULL NULL NULL NULL NULL etc. Is this a short-term clutch or will this
get more beautiful in the future?

Thanks,
Stefan
Received on 2009-05-29 12:49:27 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.