[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: design document

From: HuiHuang <yellow.flying_at_yahoo.com.cn>
Date: Fri, 29 May 2009 11:36:40 +0800

>I wasn't anticipating the change you seem to be proposing, where the
>committables are grouped by working copy.
>My redesign of the commit process long ago assumes no need to group
>committables by working copy, only by repository. Commits are driven based
>on the committable's URL today -- *not* based on its working copy path.

I see that the committing files are still grouped by working copy in native
implement of commit now, but it can be extend to group by repository. So
if "committables" you design can deal with the later situation, I can reuse it.

you say "no need to group committables by working copy, only by repository",
do you mean that "base_dir_access" in the following function is not necessary
a working copy access baton but a access baton to the base directory of
several working copies from the same repository?

cmt_err = svn_client__harvest_committables(&committables,
                                                  &lock_tokens,
                                                  base_dir_access,
                                                  rel_targets,
                                                  depth,
                                                  ! keep_locks,
                                                  changelists,
                                                  ctx,
                                                  pool)

>That's what allows us to theoretically get atomicity in a commit that spans
>multiple working copies which point to the same repository.
>Again, the code may be so stale and so tweaked by now that the design I had
>in mind is now useless. And I'm certainly not tied to those old ideas. I
>just don't want to see unnecessary effort invested if we can avoid it.

Yes, I see there is plenty of code I can reuse.

Thanks

2009-05-29

yellow.flying

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2356652

14.gif
Received on 2009-05-29 05:36:54 CEST

This is an archived mail posted to the Subversion Dev mailing list.