[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r37806 - trunk/subversion/libsvn_repos

From: Branko Cibej <brane_at_xbc.nu>
Date: Mon, 25 May 2009 23:34:25 +0200

Hyrum K. Wright wrote:
>
> On May 25, 2009, at 2:51 PM, Branko Cibej wrote:
>
>> Hyrum K. Wright wrote:
>>> On May 25, 2009, at 9:19 AM, Stefan Sperling wrote:
>>>
>>>
>>>> On Mon, May 25, 2009 at 08:08:17AM -0500, Hyrum K. Wright wrote:
>>>>
>>>>> On May 24, 2009, at 3:55 PM, Neels Janosch Hofmeyr wrote:
>>>>>
>>>>>
>>>>>> Author: neels
>>>>>> Date: Sun May 24 13:55:35 2009
>>>>>> New Revision: 37806
>>>>>>
>>>>>> Log:
>>>>>> * subversion/libsvn_repos/reporter.c (drive):
>>>>>>
>>>>> Move the function name to it's own line.
>>>>>
>>>> HACKING has examples like this:
>>>>
>>>> * dialects/nightingale.c (get_base_pitch): Allow 3/4-tone
>>>> pitch variation to account for trait variability amongst
>>>> isolated populations Erithacus megarhynchos.
>>>>
>>>
>>> Oh, so it does.
>>>
>>> It's been a while since I've seen that format used, and we've seemed
>>> to standardize on the "separate line" format. Any objections to
>>> changing that example?
>>>
>>
>> Yes. Check the logs, we have hundreds of messages like that. IIRC this
>> is even the preferred form according to GNU log message conventions,
>> which we liberally stole from. Makes no sense to change Hacking if that
>> makes tons of our logs "bad', no?
>
> Do you have many recent examples?

My last commit, I suppose ...

> We also liberally stole from the GNU coding conventions, but they
> have evolved to fit our style. Just as we still have many "spaces
> before parens" in our code, I'm not suggesting we "fix" old log
> messages, but that we pick the format which is vastly prevalent
> presently, and standardize on it moving forward.
>
> But in the end, it's a bikeshed issue, and I've got bigger fish to
> fry, so I'm not going to press it. :)

Vermilion with orange spots.

-- Brane

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2353640
Received on 2009-05-25 23:34:46 CEST

This is an archived mail posted to the Subversion Dev mailing list.