[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: segfault when deleting folders in 1.6.2

From: CC <crazycasta_at_gmail.com>
Date: Fri, 22 May 2009 18:21:47 -0700

Regardless of what's causing the issue, I would say that there should
be a check for dir_entry being NULL to avoid segfaulting.

CC

On Thu, May 21, 2009 at 1:22 AM, Stefan Küng <tortoisesvn_at_gmail.com> wrote:
> Hi,
>
> In the file libsvn_wc/adm_ops.c, function
> svn_wc_remove_from_revision_control(), line 2628:
>
>        dir_entry = apr_hash_get(parent_entries, base_name,
>                                                         APR_HASH_KEY_STRING);
>        if (dir_entry->depth != svn_depth_exclude)
>          {
>                svn_wc__entry_remove(parent_entries, base_name);
>                SVN_ERR(svn_wc__entries_write(parent_entries, parent_access, pool));
>
>          }
>
> the 'dir_entry' is NULL, and accessing it in the if-clause causes a
> segfault.
> From the crash dump I got, I can't see anything special about the path
> (it was F:\dev\svn\name\name), so no root path, no UNC path or anything
> else special I can think of.
>
> But the delete was called with --keep-local, so maybe that has something
> to do with it?
>
> Stefan
>
> --
>       ___
>  oo  // \\      "De Chelonian Mobile"
>  (_,\/ \_/ \     TortoiseSVN
>   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
>   /_/   \_\     http://tortoisesvn.net
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2343506

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2353070
Received on 2009-05-23 04:07:49 CEST

This is an archived mail posted to the Subversion Dev mailing list.