[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] docstring changes

From: Stefan Sperling <stsp_at_elego.de>
Date: Thu, 21 May 2009 11:13:47 +0100

On Thu, May 21, 2009 at 05:26:08PM +0800, Edmund wrote:
> Stefan Sperling wrote:
>
>> I am explicitly +1 on this patch without the hunks that change iffs.
>>
>> I can't commit this myself right now though, because I'm in the middle
>> of evaluating a couple of operating systems to potentially switch to.
>> My Subversion development environment is not operative right now.
>>
>
> Which operating systems are you evaluating?

I took DragonFly for a spin, but it has too many issues right now
to be usable as a production system on my laptop, unfortunately.

Now I'm on Debian, but possibly just temporarily.
During the last few years, whenever I tried going back to Linux
I eventually ended up switching back to BSD for various reasons.

>> A gentle reminder in a few days would help.
>
> Not really in a hurry about it, but might this be a good
> reminder?

Yes, thanks for the reminder. I've committed your patch in r37787.

I used a simpler log message than the one you provided.
The hunks that changed "Iff" to "If" were not committed.
I've also removed one hunk that changed "repository->working copy"
to "the repository->working copy" because in my opinion that change
didn't improve the readability of the text.

All other hunks were really good fixes! Thank you!

Stefan
Received on 2009-05-21 12:14:22 CEST

This is an archived mail posted to the Subversion Dev mailing list.