[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix links generated by ?r=REV

From: Branko Cibej <brane_at_xbc.nu>
Date: Thu, 14 May 2009 22:18:20 +0200

C. Michael Pilato wrote:
> Hyrum K. Wright wrote:
>
>> I noticed when browsing a repository using the new ?r=REV syntax for
>> GET, that the links generated by the page link to HEAD, not to the
>> revision given by r=REV. I've not hacked mod_dav_svn much, nor do I
>> have a very good way of testing the attached patch, but I *think* that
>> this works. Feedback desired.
>>
>> [[[
>> Fix links generated by mod_dav_svn when using ?r=REV syntax. At best,
>> the target isn't what the user wants. At worst, it won't even exist
>> in HEAD, even though it exists in REV.
>>
>> * subversion/mod_dav_svn/repos.c
>> (deliver): Tack on a query string to generated links to ensure that
>> linked paths exist.
>> ]]]
>>
>
> I'm fine with the concept of the patch, but r=REV is the wrong query
> parameter to add. You should use the peg revision, p=PEGREV, which will
> preserve the precise path and revision of the listed entry.
>
IMHO he should use the exact same query string as was on the original
URL. Anything else is guesswork, no?

-- Brane

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2262288
Received on 2009-05-14 22:18:40 CEST

This is an archived mail posted to the Subversion Dev mailing list.