[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r37709 - trunk/subversion/libsvn_subr

From: Bert Huijben <rhuijben_at_sharpsvn.net>
Date: Tue, 12 May 2009 17:42:01 +0200

> -----Original Message-----
> From: Arfrever Frehtes Taifersar Arahesis [mailto:Arfrever.FTA_at_GMail.Com]
> Sent: dinsdag 12 mei 2009 17:31
> To: svn_at_subversion.tigris.org
> Subject: svn commit: r37709 - trunk/subversion/libsvn_subr
>
> Author: arfrever
> Date: Tue May 12 08:30:42 2009
> New Revision: 37709
>
> Log:
> When SVN_DEBUG is defined, print error messages containing details about
> failures of dynamic loading of libraries performed by apr_dso_load().
>
> * subversion/libsvn_subr/dso.c
> (svn_dso_load): Print message retrieved by apr_dso_error().

Why is this necessary?

If the error is useful, the full error message can be returned (as wrapped
error?) in the svn_error_t* returned by this function and if it is not, what
is the use of printing it in debug mode?

        Bert
>
> Modified:
> trunk/subversion/libsvn_subr/dso.c
>
> Modified: trunk/subversion/libsvn_subr/dso.c
> URL:
>
http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_subr/dso.c?pathrev=
37
> 709&r1=37708&r2=37709
>
============================================================================
==
> --- trunk/subversion/libsvn_subr/dso.c Tue May 12 08:29:24 2009
(r37708)
> +++ trunk/subversion/libsvn_subr/dso.c Tue May 12 08:30:42 2009
(r37709)
> @@ -98,6 +98,10 @@ svn_dso_load(apr_dso_handle_t **dso, con
> status = apr_dso_load(dso, fname, dso_pool);
> if (status)
> {
> +#ifdef SVN_DEBUG
> + char buf[1024];
> + fprintf(stderr, "%s\n", apr_dso_error(*dso, buf, 1024));
> +#endif
> *dso = NULL;
>
> /* It wasn't found, so set the special "we didn't find it"
value.
> */
>
> ------------------------------------------------------
>
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=221
59
> 43

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2216038
Received on 2009-05-12 17:42:32 CEST

This is an archived mail posted to the Subversion Dev mailing list.