[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r37662 - in trunk/subversion: include libsvn_subr mod_dav_svn

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Mon, 11 May 2009 09:16:51 -0400

Hyrum K. Wright wrote:
>>>> +
>>>> + /* If we get here, there had better be a real link in this error
>>>> chain. */
>>>> + assert(new_err_leaf);
>>>
>>> Perhaps use SVN_ERR_ASSERT()?
>>
>> FYI, this call to assert() even breaks compilation on systems with
>> non-ancient compiler:
>> subversion/libsvn_subr/error.c: In function ‘svn_err_purge_tracing’:
>> subversion/libsvn_subr/error.c:361: error: implicit declaration of
>> function ‘assert’
>> subversion/libsvn_subr/error.c:361: warning: nested extern declaration
>> of ‘assert’
>> subversion/libsvn_subr/error.c: In function
>> ‘svn_error_abort_on_malfunction’:
>> subversion/libsvn_subr/error.c:595: warning: will never be executed
>>
>> http://crest.ics.uci.edu/buildbot/builders/x64-ubuntu%20gcc/builds/553/steps/Build/logs/stdio/text
>>
>
>
> Mike,
> Ordinarily, I like to let people fix their own bugs, but just to get the
> build working again, I committed this in r37666. Feel free to tweak as
> needed.

Thanks.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2190278

Received on 2009-05-11 15:17:51 CEST

This is an archived mail posted to the Subversion Dev mailing list.