[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r37650 - trunk/subversion/tests/cmdline/svntest

From: Greg Stein <gstein_at_gmail.com>
Date: Sat, 9 May 2009 05:05:02 +0200

Nope. Just pointing out the rationale for the prior behavior.

I might suggest, however, altering the TIME= output to make it more
easily linked-up with the command. For example:

CMD: blather some args go here
CMD: -- TIME = xyz
CMD: horkus all over
CMD: -- TIME = abc

The current output kinda dissociates some of that stuff.

Cheers,
-g

On Sat, May 9, 2009 at 03:56, Hyrum K. Wright
<hyrum_wright_at_mail.utexas.edu> wrote:
> Hmm, well that behavior certainly fouls up 'DBG: ...' statements being
> noticeable.  Suggestions?
>
> On May 8, 2009, at 7:38 PM, Greg Stein wrote:
>
>> These functions did not print a newline because they expected the
>> TIME= line to be printed at their completion, on the same line.
>>
>> On Fri, May 8, 2009 at 23:21, Hyrum K. Wright <hyrum_at_hyrumwright.org>
>> wrote:
>>>
>>> Author: hwright
>>> Date: Fri May  8 14:21:52 2009
>>> New Revision: 37650
>>>
>>> Log:
>>> Improve test log, espeically when using SVN_DBG().
>>>
>>> * subversion/tests/cmdline/svntest/main.py
>>>  (spawn_process, copy_repos): Add some needed newlines to the log output.
>>>
>>> Modified:
>>>  trunk/subversion/tests/cmdline/svntest/main.py
>>>
>>> Modified: trunk/subversion/tests/cmdline/svntest/main.py
>>> URL:
>>> http://svn.collab.net/viewvc/svn/trunk/subversion/tests/cmdline/svntest/main.py?pathrev=37650&r1=37649&r2=37650
>>>
>>> ==============================================================================
>>> --- trunk/subversion/tests/cmdline/svntest/main.py      Fri May  8
>>> 14:06:59 2009        (r37649)
>>> +++ trunk/subversion/tests/cmdline/svntest/main.py      Fri May  8
>>> 14:21:52 2009        (r37650)
>>> @@ -461,7 +461,7 @@ def spawn_process(command, binary_mode=0
>>>
>>>  # Log the command line
>>>  if verbose_mode and not command.endswith('.py'):
>>> -    sys.stdout.write('CMD: %s %s ' % (os.path.basename(command),
>>> +    sys.stdout.write('CMD: %s %s\n' % (os.path.basename(command),
>>>                                      ' '.join([_quote_arg(x) for x in
>>> varargs])))
>>>    sys.stdout.flush()
>>>
>>> @@ -785,7 +785,7 @@ def copy_repos(src_path, dst_path, head_
>>>  if ignore_uuid:
>>>    load_args = load_args + ['--ignore-uuid']
>>>  if verbose_mode:
>>> -    sys.stdout.write('CMD: %s%s | %s%s ' %
>>> (os.path.basename(svnadmin_binary),
>>> +    sys.stdout.write('CMD: %s%s | %s%s\n' %
>>> (os.path.basename(svnadmin_binary),
>>>                                            ' '.join(dump_args),
>>>
>>>  os.path.basename(svnadmin_binary),
>>>                                            ' '.join(load_args)))
>>>
>>> ------------------------------------------------------
>>>
>>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=2122421
>>>
>>
>> ------------------------------------------------------
>>
>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2127053
>
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2130048
Received on 2009-05-09 05:05:49 CEST

This is an archived mail posted to the Subversion Dev mailing list.