[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add NNTP support to mailer.py

From: Gavin Baumanis <gavinb_at_thespidernet.com>
Date: Thu, 7 May 2009 23:18:41 +1000

Lars / Jon,

Can I bother you both, please.
Can I get confirmation that Jon's last patch is appropriate and works
as required?

Since your posts have received little (outside of you two) extra
attention I intend to "file" the patch into the issue tracker, but
want to ensure that the correct patch is used.

Gavin.

On 01/05/2009, at 9:16 PM, Gavin 'Beau' Baumanis wrote:

> Ping. This patch proposal has received no comments in over a week.
>
> Gavin.
>
>
> On 23/04/2009, at 7:10 PM, Jon Bendtsen wrote:
>
>> On 22/04/2009, at 20.07, Lars Gullik Bjønnes wrote:
>>
>>> Lars Gullik Bjønnes <lgb_at_tandberg.com> writes:
>>>
>>> | | Imagine that you have no default values, but control everything
>>> with
>>> | | [maps]. Then it is impossible to only email, or only nntp, which
>>> | | someone might want to do.
>>>>
>>> | The to_group error is mine, but the to_addr one is pre-existing I
>>> | think.
>>>>
>>> | Anyways. I'll look into this and see if things can be made a bit
>>> more
>>> | robust.
>>>
>>> I think this change makes it more robust. What I do not like about
>>> it
>>> is that if you setup smtp_hostname and/or nntp_hostname and forget
>>> to_addr and to_group you will just not get any output/messages at
>>> all.
>>
>> well, what if you have some part of your SVN that you dont want email
>> for?
>> But you want to be able to commit anyway.
>> Or if you dont want a default email/usenet address, but want to
>> control it with maps?
>>
>> I think it would be annoying if the committer got an "error" message
>> saying that
>> there is no address to send to.
>>
>>
>>> Note that this is completely untested.
>>
>> i just tested it (in my patch from yesterday) and i dont have any
>> problems.
>>
>>
>>
>> JonB
>>
>> ------------------------------------------------------
>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1875442
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2094821
Received on 2009-05-07 15:19:13 CEST

This is an archived mail posted to the Subversion Dev mailing list.