[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Patch]: [Issue 2367] get rid of "... | N lines" slot in log message header

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 6 May 2009 14:50:37 +0200

On Wed, May 6, 2009 at 14:46, Hyrum K. Wright
<hyrum_wright_at_mail.utexas.edu> wrote:
>
> On May 6, 2009, at 4:45 AM, Greg Stein wrote:
>
>> On Wed, May 6, 2009 at 11:16,  <webpost_at_tigris.org> wrote:
>>>
>>> Hi,
>>>
>>> Karl:
>>>>
>>>> Thanks for the patch -- but you may have missed the big thing about
>>>> this issue: that the change can't be made before 2.0, because of
>>>> interface promises.  (Anyway, we'd have to discuss it a lot to change
>>>> it before then.)  That's why the issue is set so far in the future.
>>>
>>> Is there an estimated date for 2.0? Even if the "line" string is bearable
>>> noise for the user, "svn log" still lacks a short summary of the size of a
>>> commit in the style of cvs log "line" field.
>>
>> We have no thoughts on 2.0 at all. That would break compatibility with
>> a huge ecosystem of tools built upon Subversion. Nobody wants to rock
>> the boat that hard, and I don't think it would really be all that
>> great for end-users losing much of their toolset that way.
>>
>>> Couldn't we provide this kind of information by just an extra option to
>>> svn log so that compatibility is preserved?
>>
>> We could, yes. The problem is that we store changes differently from
>> CVS. There is no simple "it changed N lines and added N lines" for a
>> given change (because we do binary deltas -- character by character;
>> we'd have to reconstruct files to detect line-based changes). CVS does
>> this file by file, but we'd want to summarize the whole revision, so
>> we'd have to total these deltas across all files touched by the
>> commit.
>
> I'm not completely familiar with CVS log output, but if you're looking for
> "number of lines added, number of lines removed" type of output, I'd think
> 'svn diff' piped to 'diffstat' would work.  Something like:
>
> $ svn diff -c12345 | diffstat

Sure, but I think he's looking for a quick summary as part of the 'svn
log' output. That diff command over all changed files is relatively
expensive.

I could see a post-commit hook computing that info tho...

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2080527
Received on 2009-05-06 14:51:04 CEST

This is an archived mail posted to the Subversion Dev mailing list.