[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: revprop packing for fsfs

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 29 Apr 2009 09:58:43 +0300 (Jerusalem Daylight Time)

Peter Samuelson wrote on Tue, 28 Apr 2009 at 16:50 -0500:
>
> [Paul Querna]
> > Last time this was discussed was in October 2008[3], when hwright had
> > packed revprops, but later reverted the work as revprops are mutable
> > in r33724.
>
> Is there a reason to try too hard to avoid allocation holes in the
> revprops file? Seems to me you could just align each revision to, say,
> 16 or 32 bytes, and if a propedit operation wants to make it too big to
> fit, you move it to the end.

> Maybe increment a "hole counter" and if that gets to be too large
> a fraction of shard size, take a lock and repack the file.
>

How can you do the "repacking" step atomically?

Daniel

> This would only be problematic if some automated process were to edit a
> lot of revprops from comparatively old revisions. (Which I honestly
> don't think is a case worth optimizing for.)
>
> > My question for the list: Is the design of using SQLite as the primary
> > data storage for revprops acceptable?
>
> A flat file seems preferable, unless there are serious problems with
> that which I haven't seen.
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1976067
Received on 2009-04-29 10:10:12 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.