Re: [PATCH] Add NNTP support to mailer.py

On 22/04/2009, at 20.07, Lars Gullik Bjønnes wrote:

> Lars Gullik Bjønnes <lgb_at_tandberg.com> writes:
>
> | | Imagine that you have no default values, but control everything
> with
> | | [maps]. Then it is impossible to only email, or only nntp, which
> | | someone might want to do.
>>
> | The to_group error is mine, but the to_addr one is pre-existing I
> | think.
>>
> | Anyways. I'll look into this and see if things can be made a bit
> more
> | robust.
>
> I think this change makes it more robust. What I do not like about it
> is that if you setup smtp_hostname and/or nntp_hostname and forget
> to_addr and to_group you will just not get any output/messages at all.

well, what if you have some part of your SVN that you dont want email
for?
But you want to be able to commit anyway.
Or if you dont want a default email/usenet address, but want to
control it with maps?

I think it would be annoying if the committer got an "error" message
saying that
there is no address to send to.

> Note that this is completely untested.

i just tested it (in my patch from yesterday) and i dont have any
problems.

JonB

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1875442
Received on 2009-04-23 11:39:56 CEST