[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: r37413 and basic test 14

From: Bert Huijben <rhuijben_at_sharpsvn.net>
Date: Wed, 22 Apr 2009 13:14:17 +0200

> -----Original Message-----
> From: Hyrum K. Wright [mailto:hyrum_wright_at_mail.utexas.edu]
> Sent: dinsdag 21 april 2009 22:57
> To: Bert Huijben
> Cc: dev_at_subversion.tigris.org
> Subject: r37413 and basic test 14
>
> Bert,
> I think that r37413 will solve the wc-ng windows problems with basic
> test 14, and possibly others. Can you check and let me know how it
> goes?

My last status on Windows is:

At least one test FAILED, checking F:\svn-2008\dev\Debug\tests.log
FAIL: update_tests.py 8: update after add/rm of deleted state
FAIL: update_tests.py 34: update handles obstructing paths scheduled for
add
FAIL: switch_tests.py 1: test some basic switching operations
FAIL: switch_tests.py 2: commits after some basic switching operations
FAIL: switch_tests.py 3: update wc that contains switched things
FAIL: switch_tests.py 4: reverse update wc that contains switched things
FAIL: switch_tests.py 5: update switched wc things to HEAD
FAIL: switch_tests.py 6: reverse update switched wc things to an older rev
FAIL: switch_tests.py 7: show logs for a switched file
FAIL: switch_tests.py 25: basic tests to verify switch along with depth
FAIL: switch_tests.py 30: tolerate deletion of a directory with local mods
FAIL: merge_tests.py 4: some simple property merges
FAIL: tree_conflict_tests.py 7: up/sw dir: del/rpl/mv onto del/rpl/mv
FAIL: upgrade_tests.py 1: basic upgrade behavior
FAIL: upgrade_tests.py 2: test upgrading from a 1.5-era working copy
Summary of test results:
  798 tests PASSED
  40 tests SKIPPED
  28 tests XFAILED
  15 tests FAILED

update_tests.py 8 is now a new wc.db deletion error (file in use: can't
delete); I haven't investigated this one further.

Update_tests.py 34 is the tree conflict discussed in the "bug in add/add
tree conflict?" thread on dev_at_s.t.o.

All the switch tests, the merge test and the tree conflict test go through
the same shortcut in update_editor.c (around line 2141).

Described in:
if (eb->switch_url)
    {
      /* The SVN_WC__LOG_DELETE_ENTRY log item will cause
       * svn_wc_remove_from_revision_control() to be run. But that
       * function checks whether the deletion target's URL is child of
       * its parent directory's URL, and if it's not, then the entry
       * in parent won't be deleted (because presumably the child
       * represents a disjoint working copy, i.e., it is a wc_root).
       *
       * However, during a switch this works against us, because by
       * the time we get here, the parent's URL has already been
       * changed. So we manually remove the child from revision
       * control after the delete-entry item has been written in the
       * parent's log, but before it is run, so the only work left for
       * the log item is to remove the entry in the parent directory.
       */

And it then continues with unversioning the directory without closing the
handles first.

        Bert

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1858851
Received on 2009-04-22 13:15:06 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.