[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r37369 - in trunk: . build (transform_libtool_scripts.sh)

From: Arfrever Frehtes Taifersar Arahesis <Arfrever.FTA_at_GMail.Com>
Date: Tue, 21 Apr 2009 05:42:04 +0200

2009-04-21 00:10:09 Max Bowsher (test unpriv account) napisaƂ(a):
> Arfrever Frehtes Taifersar Arahesis wrote:
> > Author: arfrever
> > Date: Sun Apr 19 12:32:18 2009
> > New Revision: 37369
> >
> > Log:
> > Use LD_PRELOAD to ensure that locally built Subversion libraries are used.
> >
> > * Makefile.in
> > (local-all): Depend on 'transform-libtool-scripts' rule.
> > (transform-libtool-scripts): New rule which calls
> > 'build/transform_libtool_scripts.sh'.
> >
> > * build/transform_libtool_scripts.sh: New script which adds definitions of
> > LD_PRELOAD to libtool wrapper scripts.
>
>
> This approach seems rather far into the category of unpleasant hack to
> me. I certainly feel that if it's a development-time convenience, it's
> too ugly to allowed to occur in release builds.

Currently local-all rule depends on transform-libtool-scripts rule, but
I think that a new rule called e.g. 'dev' could be created and it would
depend on transform-libtool-scripts rule.

> There's also the problem that it seems to be duplicating a lot of
> dependency information that formerly was nicely centralized in
> build.conf for the most part.
>
> IIUC the idea here is to affect the loading path for libs loaded via
> svn_dso_load ? In which case, why is simply setting an appropriate
> LD_LIBRARY_PATH not an acceptable solution?

Subversion executables have rpath=$(libdir) which takes precedence over
LD_LIBRARY_PATH. LD_LIBRARY_PATH specified in libtool wrapper scripts
has partially wrong value.

-- 
Arfrever Frehtes Taifersar Arahesis

Received on 2009-04-21 05:41:42 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.