Re: boolean issue with serf

Greg Stein wrote:
> On Sat, Apr 18, 2009 at 14:07, Stefan Küng <tortoisesvn_at_gmail.com> wrote:
>> ...
>> I've attached a patch which replaces all if(xxx == TRUE) statements with
>> if(xxx) (well, all that I found in trunk with a simple grep search).
>>
>> Not sure about the commit message though: is it really necessary to list
>> all functions that are affected for such a change?
>
> I'd say "nah, don't bother."

With the log message or the commit?

> I'd also recommend the log message uses svn-style for the code :-)
> (space after 'if' and no extra in-paren spaces)

Sure, will do.

> And lastly, I'd suggest you update your code to pass 0/1 rather than
> 0/nonzero for svn_boolean_t. Who knows what other code might be
> written "knowing" that an svn_boolean_t only has 0 or 1 values.

That I will definitely do.

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1791856