upgrade test failures

Hey Hyrum,

I saw a couple core dumps from my wc-ng test run and took a look at
one. This was from one of the upgrade tests. The problem is pretty
easy to explain... solution? Euh...

We point DB at a v11 directory, and it records that in a wcroot_t
structure. There is no SDB for v11, so that member is NULL.

Later, we come along and say "no. make that directory v12." But we
don't update the SDB or WC_ID members of the structure. When code
later executes, it says "oh, v12!" and proceeds to use the SDB. BOOM.

Normally, the SDB is created when the wcroot_t is created. And we read
the format at that time. The reset_format is monkeying with our
expectations.

I think the right answer is to have wc_db *forget* the wcroot_t
structure (just store NULL; the PDH can stick around). Then call
wc_db__init() for the directory in question. Next time wc_db looks at
the directory, it will detect the version as a v12 directory.

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1760710
Received on 2009-04-17 06:33:34 CEST