boolean issue with serf

Hi,

A user reported a strange problem that happens only with TSVN and serf,
but not with the CL client.
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=1752435

After some testing I found that TSVN passes a value of 32 as 'true' to
svn_client_lock for the --force flag. This works ok when using neon, but
fails when using serf. If I pass 1 instead of 32 then serf works too.

Now while I can fix this easily in TSVN, I'm wondering if it's really
required to pass 1 as svn_boolean_t values? Shouldn't all comparisons be
done as !=0 instead of == 1 in C since it doesn't have a bool type?

I haven't stepped through the serf code to find out where the comparison
is that fails if I pass 32 as 'TRUE' though...

Stefan

-- 
       ___
  oo  // \\      "De Chelonian Mobile"
 (_,\/ \_/ \     TortoiseSVN
   \ \_/_\_/>    The coolest Interface to (Sub)Version Control
   /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1753422