On Thu, Apr 16, 2009 at 1:54 PM, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> [ CCing the list again, per discussion ]
>
> B Smith-Mannschott wrote on Mon, 13 Apr 2009 at 14:54 +0200:
..
>
>> >> + /* Now that we have assured that there will be an svn:log message,
>> >> + normalize line breaks in log message.*/
>> >> + if (getenv("SVNSYNC_UNSUPPORTED_NORMALIZE_PROP_EOL_STYLE"))
>> >> + {
>> >> + svn_string_t *svn_log;
>> >> + svn_log = apr_hash_get(filtered, SVN_PROP_REVISION_LOG,
>> >> + APR_HASH_KEY_STRING);
>> >> + svn_log = svn_string_with_normalized_eol_style(svn_log, pool);
>> >> + apr_hash_set(filtered, SVN_PROP_REVISION_LOG, APR_HASH_KEY_STRING,
>> >> + svn_log);
>> >> + }
>> >> +
I'd rather have we make this an option to svnsync instead of using an
environment var. If we agree we want this behavior in svnsync (and I
do agree), we want to make this option as clear as possible to the end
users. Hiding it in the environment is not the way to go!
Lieven
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1746296
Received on 2009-04-16 14:17:35 CEST