Re: svn commit: r37294 - in trunk/subversion: include libsvn_client libsvn_wc tests/cmdline tests/cmdline/svntest

2009-04-16 13:33 Stefan Sperling <stsp_at_elego.de> napisał(a):
> On Thu, Apr 16, 2009 at 12:31:42PM +0100, Stefan Sperling wrote:
>> On Thu, Apr 16, 2009 at 12:55:30PM +0200, Arfrever Frehtes Taifersar Arahesis wrote:
>> > Public svn_wc_apply_svnpatch() function still exists. Would it make
>> > sense to have a public function which applies unidiff parts of
>> > patches?
>>
>> Quite possibly, yes. We can make a new one, or promote the
>> apply_textdiffs() function in libsvn_client/patch.c to public.

So the code which applies unidiff parts of patches is in libsvn_client,
while the code which applies SVNPATCH1 blocks is in libsvn_wc?
If yes, is this discrepancy intentional?

> On second thought, one public function should be enough.
> It should accept both svnpatches or unidiffs, and do the right thing
> for each.

+1.

--
Arfrever Frehtes Taifersar Arahesis
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1745936