Hi Stefan,
Stefan Sperling wrote:
> On Wed, Apr 15, 2009 at 04:04:24PM +0530, Senthil Kumaran S wrote:
>> (02:35:23 PM) stylesen: in
>> "/subversion-dev/trunk/subversion/libsvn_wc/update_editor.c", line 5358I am
>> trying to change the if check, to check for uuid and not ancestral relation
>> (02:35:37 PM) stylesen: which fails on different url schemes
>> (02:36:21 PM) gstein: you do not have enough information at that point in the
>> code to fix that check
>
>> The attached patch removes the check for scheme (of url) during a merge, which
>> IMHO is not required, since we already know we are operating with the same
>> repository
>
> That statement seems to contradict what gstein said in the chat.
> Which is correct?
It checks whether the copyfrom URL is using the same scheme as the working copy
repository url, just in order to record the correct copy from url in the
entries, which has a redundant check in update editor too. Hence I think this
check is not necessary here, since we already do a check for same repositories
using the uuid, so it is safe to remove this check here.
>> + /* ### TODO: Here we need to check copyfrom_url and ent->repos are from
>> + ### the same repository by checking their UUIDs, which should be
>> + ### trivial in wc-ng and avoids opening an ra_session here. */
>
> Why is opening an RA session a problem?
>
> Sure, performance will suffer, but if we need that information to make
> the check correct, we have to get it to make the check correct.
For performance reasons only.
> and forget about fixing the problem for wc-1. Otherwise, we go for the
> RA session for now, and make the check use information available in
> wc-ng as soon as possible, too.
I shall try to create an ra session and make the commit.
Thank You.
--
Senthil Kumaran S
http://www.stylesen.org/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1740637
Received on 2009-04-16 08:12:57 CEST