[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Update HACKING: Mutual respect / Evaluate the code, not the coder.

From: Jack Repenning <jrepenning_at_collab.net>
Date: Wed, 15 Apr 2009 12:12:04 -0700

On Apr 15, 2009, at 10:43 AM, Greg Stein wrote:

> Stefan Sperling ran into a problem where the ML software munged his
> patch. Basically, it *rewrote* the message into something that was
> *incorrect*. It said "quoted-printable", but the content was wrong.

I'm aware of quoted-printable botches over the message *body*,
including bodies that stupidly get converted to attachments, but not
for things that start out as attachments. I've worked some of the
former cases with Stefan. Can you link me to an example of the latter?

> Oh. And I'm still waiting to see a solution to correct the "this
> message has been converted to an attachment". I thought you said that
> was solved by making the message delivery a passthru, and the
> conversion would only happen for he web UI. What happened to that?

Still in the pipeline. The argument (which you may have just refuted,
above) was that true attachments are safe, whatever butchery is
happening to the bodies, and so key uses such as patch-based change
review are doable. That, so the theory goes, lowers the priority of
the "don't convert bodies to attachments in the first place, you
ninny" fix to "next scheduled release." FYI: we basically have three
degrees of urgency:

  - Next scheduled release (typically, quarterly)
  - Next scheduled (typically, monthly)
  - Hot fix (can turn around in hours)

To recap: in this thread, we've discussed (or veered very near) the
following problems:

  - Dropping "inline" attachments entirely: PCN 65761. Scheduled fix:
5.3. Currently hot-fixed onto Tigris.

  - Stupidly converting bodies to attachments: PCN 65675. Scheduled
fix: Patch 3.

  - Quoted-printable botch of body text: PCN 65997. Scheduled fix: 5.3.

  - Quoted-printable botch of things that actually started out as
attachments: that would be new; show me, show me!

Tigris is currently on 5.2.0 patch 2, with a hot fix or two. The slick
way to learn that requires administrative privs, but any user can use
the sneaky way: "View Source" on any Tigris page, and scan down for
this:

     <meta name="version" content="5.2.0.140.2" />

That means "Release 5.2.0" and "patch 2." The "140" in the middle is
the build number of the final release of 5.2.0; that leaked into the
version number at some point, but isn't particularly helpful for any
deployed system (you'll never see any number other than 140 for a
deployed 5.2.0, for example).

-==-
Jack Repenning
Chief Technology Officer
CollabNet, Inc.
8000 Marina Boulevard, Suite 600
Brisbane, California 94005
office: +1 650.228.2562
mobile: +1 408.835.8090
raindance: +1 877.326.2337, x844.7461
aim: jackrepenning
skype: jackrepenning
twitter: http://twitter.com/jrep

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1731263
Received on 2009-04-15 21:12:45 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.