Now reviewing the actual change...
On Apr 14, 2009, at 11:54 PM, Gavin Baumanis wrote:
> Hi Hyrum,
>
> I'm obviously doing something incorrectly... but not too sure what
> that is.
>
> The file *is* plain text;
> created with;
>
> svn diff www/hacking.html > hacking.html.diff
>
> The file opens correctly on my Mac.
> Whether I use VI or (Mac's) TextEdit.app application.
>
> And while assumption *IS* the mother of of stuff-ups - I have
> associated both of those file extensions with TextEdit.app and thusly
> assumed that specifying .patch or .diff would be sufficient to ensure
> the correct MIME type was applied to the attachment.
>
> Anyway, here it is again - with a TXT extension.
> In a an email to myself, the header reads;
>
> Content-Disposition: attachment;
> filename=hacking.html.txt
> Content-Type: text/plain;
> x-unix-mode=0644;
> name="hacking.html.txt"
> Content-Transfer-Encoding: 7bit
>
> Hopefully this is sufficient - otherwise I might need some help from a
> MAC savvy list member.
> Index: hacking.html
> ===================================================================
> --- hacking.html (revision 37267)
> +++ hacking.html (working copy)
> @@ -139,6 +139,20 @@
> >http://subversion.tigris.org/servlets/
ProjectMailingListList</a>
> in the description for the svn-breakage list.</p>
>
> +<p>Finally, despite the online nature of the subversion project /
community it is
Subversion should be capitalized, and I would pick either "project" or
"community", not both.
> +important to realise that there are <em>real</em> people at the
end of all
"realize", says my anglo-centric spell-o-matic.
> +contributions. Ensure that you treat all other community members
in a
> +manner to which you would expect to be treated yourself.</p>
> +
> +<p>When performing a review of a contribution ensure that your
review is
> +of the contribution and not the contributor.</p>
> +
> +<p>Simply;</p>
^
colon, not semi-colon
> +<ul>
> +<li><p>Treat everyone with respect,</p></li>
> +<li><p>Do not excessively annoy another,</p></li>
> +<li><p>Do not allow yourself to be excessively annoyed.</p></li>
> +</ul>
> </div>
And I'd use consistent '.' at the end of each item in the bulleted list.
Those are all grammar nits, maybe not even worth mentioning. The idea
of the patch is good, though.
-Hyrum
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1727689
Received on 2009-04-15 16:12:10 CEST